Files
darktide-AutoMark/AutoMark/scripts
michael a18194519b review: prod-readiness fix pass (3-agent code review + 2 self-found)
HIGH:
- rpc shadow dropped tagger_game_object_id and target_location (wrong vararg capture,
  args shifted); now forwards all varargs verbatim via unpack
- rpc shadow could NEVER install: ensure() read context.smart_tag_system (client-side
  instance) instead of the updating self; now armed per-instance, client shadow still
  pinned to the context instance only
- on_setting_changed debug_mode branch returned before the snapshot write: Debug Mode
  toggles were dead mid-session and the ON-notify read the stale value (AGENTS.md trap
  again, in my own fix); debug_chat/debug_hud now update the snapshot live too
- capacitance retention unit bug: widget relabel to charges (-10..10) left the legacy
  /100 in load + change handler + breed menu round-trip (*100) + breed setter (/100),
  making every retention threshold 100x too small; removed all four conversions
  (health-threshold percent semantics untouched)

MEDIUM:
- TARGETS capture was observer-non-neutral: MARKED candidate fell through into full
  re-evaluation (burned shared visibility budget); now skips like vanilla
- omni_diag_counter was an implicit global incremented in the prod hot path; now a
  file-local, only touched under debug_mode
- hack skull/check/blacklist state survived mission end (stale unit handles + stamped
  _automark_hack_order flags); mod:reset_servo_skull_local_state() runs on state exit,
  which also clears omni_last/omni_candidates/last_skull_confirm/banners

LOW: dead-tag release now honors per-class reset_cooldown; SERVO_SKULL gate checks class
before doing GameSession reads; mod:diag hard-gated on debug_mode internally (diag_log.txt
is never created for normal users anymore; un-gates OMNI-BOOT/banner/load probes); hits[]
pooled per call; early no-candidates return no longer dangles omni_rejects/omni_hud_units;
omni_last allocation gated on hud_capture; omni_hud_cur reset at entry and per-iteration
before actor resolution (no cross-candidate leakage); builder runs only while a level
world exists (no menu-side pcall spam); debug_hud_y fallback 24->0 matches default;
px unit_text localization added; six new widgets had orphan *_tooltip loc keys - DMF
only shows tooltips via an explicit tooltip field, added
2026-10-04 11:18:23 -04:00
..